Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding instant as non-reserved keyword #361

Merged
merged 1 commit into from
Aug 7, 2024
Merged

adding instant as non-reserved keyword #361

merged 1 commit into from
Aug 7, 2024

Conversation

jycor
Copy link

@jycor jycor commented Aug 7, 2024

The INSTANT keyword isn't in the MySQL docs, but it is a non reserved keyword.
MySQL Docs: https://dev.mysql.com/doc/refman/8.4/en/keywords.html

fixes: dolthub/dolt#8220

@jycor jycor requested a review from zachmu as a code owner August 7, 2024 17:07
@jycor jycor changed the title adding instant keyword as non reserved adding instant as non-reserved keyword Aug 7, 2024
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@jycor jycor merged commit 71d7350 into main Aug 7, 2024
4 checks passed
@jycor jycor deleted the james/instant branch August 7, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Correctness Issue, queries run differently on MySQL and Dolt
2 participants